feat(extra-natives/five): GET_WEAPON_ACCURACY_SPREAD & SET_WEAPON_ACC… #3356
Conversation
github-actions
bot
added
the
triage
|
Looks good. |
| accuracy_spread = *(int*)(weapon + weapon_spread_offset); | ||
| } | ||
|
|
||
| context.SetResult<int>(accuracy_spread); |
There was a problem hiding this comment.
Why in GET we return it as int and in SET we set float?
|
|
||
| if (auto weapon = getWeaponFromHash(context)) | ||
| { | ||
| accuracy_spread = *(int*)(weapon + weapon_spread_offset); |
There was a problem hiding this comment.
Could you use hook::FlexStruct to make this code easier to read please?
There was a problem hiding this comment.
And same notice about variable name styling
| @@ -354,6 +355,7 @@ static HookFunction hookFunction([]() | |||
| WeaponDamageModifierOffset = *hook::get_pattern<int>("48 8B 0C F8 89 B1", 6); | |||
| WeaponAnimationOverrideOffset = *hook::get_pattern<int>("8B 9F ? ? ? ? 85 DB 75 3E", 2); | |||
| WeaponRecoilShakeAmplitudeOffset = *hook::get_pattern<int>("48 8B 47 40 F3 0F 10 B0 ? ? ? ?", 8); | |||
| weapon_spread_offset = *hook::get_pattern<uint8_t>("F3 0F 59 59 ? F3 0F 59 D8", 4); | |||
There was a problem hiding this comment.
Use same name styling as above please
|
@bleenobtw can you squash the commits? and they're most likely going to merge this pull request. 😁 |
They get squashed when merged. |
No, they don't. We are not merging using GitHub, I'm doing it manually and if I squash your commits on my side - I will be mentioned as "committed by". |
…URACY_SPREAD feat(extra-natives/five): fix variable naming conventions, using flexstruct and getter now uses a float
bleenobtw
force-pushed
the
feat/accuracy-spread-natives
branch
from
6bb79d3 to
c73d9da
Compare
Sorry for the confusion, should be good! Thanks for the review. |
Goal of this PR
Introduces a way for client scripts to get & set the accuracy spread value of a weapon via it's hash.
How is this PR achieving the goal
By introducing
GET_WEAPON_ACCURACY_SPREAD&GET_WEAPON_ACCURACY_SPREADto allow client scripts to retrieve and set the spread of a weapon.This PR applies to the following area(s)
FiveM, Natives
Successfully tested on
Game builds: 2062, 3095, 3258
Platforms: Windows
Checklist
Fixes issues